Skip to content

Fix constexpr error with vs2019 with half #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9prady9 merged 1 commit into from
Nov 16, 2020
Merged

Fix constexpr error with vs2019 with half #3049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/backend/common/half.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,15 +879,9 @@ class alignas(2) half {
return *this;
}

#if defined(NVCC) || defined(__CUDACC_RTC__)
AF_CONSTEXPR __DH__ explicit half(__half value) noexcept
#ifdef __CUDA_ARCH__
: data_(value) {
}
#else
: data_(*reinterpret_cast<native_half_t*>(&value)) {
}
#endif
AF_CONSTEXPR __DH__ explicit half(__half value) noexcept : data_(value) {}

AF_CONSTEXPR __DH__ half& operator=(__half value) noexcept {
// NOTE Assignment to ushort from __half only works with device code.
// using memcpy instead
Expand Down