Skip to content

Max parameter length fetched from device #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9prady9 merged 2 commits into from
Nov 4, 2020
Merged

Max parameter length fetched from device #3032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e2b5ff
Max parameter length is now fetched from device.
willyborn Oct 26, 2020
0f161f2
Removed isAmd & isNvidia, since they are no longer used.
willyborn Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 7 additions & 25 deletions src/backend/opencl/Array.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,6 @@ kJITHeuristics passesJitHeuristics(Node *root_node) {
auto platform = getActivePlatform();

// The Apple platform can have the nvidia card or the AMD card
bool isNvidia =
platform == AFCL_PLATFORM_NVIDIA || platform == AFCL_PLATFORM_APPLE;
bool isAmd =
platform == AFCL_PLATFORM_AMD || platform == AFCL_PLATFORM_APPLE;
bool isIntel = platform == AFCL_PLATFORM_INTEL;

/// Intels param_size limit is much smaller than the other platforms
Expand All @@ -320,27 +316,13 @@ kJITHeuristics passesJitHeuristics(Node *root_node) {
constexpr size_t base_param_size =
sizeof(T *) + sizeof(KParam) + (3 * sizeof(uint));

// This is the maximum size of the params that can be allowed by the
// CUDA platform.
constexpr size_t max_nvidia_param_size = (4096 - base_param_size);
constexpr size_t max_amd_param_size = (3520 - base_param_size);

// This value is really for the Intel HD Graphics platform. The CPU
// platform seems like it can handle unlimited parameters but the
// compile times become very large.
constexpr size_t max_intel_igpu_param_size =
(1024 - 256 - base_param_size);

size_t max_param_size = 0;
if (isNvidia) {
max_param_size = max_nvidia_param_size;
} else if (isAmd) {
max_param_size = max_amd_param_size;
} else if (isIntel && getDeviceType() == CL_DEVICE_TYPE_GPU) {
max_param_size = max_intel_igpu_param_size;
} else {
max_param_size = 8192;
}
const cl::Device &device = getDevice();
size_t max_param_size = device.getInfo<CL_DEVICE_MAX_PARAMETER_SIZE>();
// typical values:
// NVIDIA = 4096
// AMD = 3520 (AMD A10 iGPU = 1024)
// Intel iGPU = 1024
max_param_size -= base_param_size;

struct tree_info {
size_t total_buffer_size;
Expand Down