Skip to content

Pthread fix - #1872

Merged
umar456 merged 2 commits into
arrayfire:hotfix-3.5.1from
umar456:pthread_fix
Jul 19, 2017
Merged

umar456 merged 2 commits into
arrayfire:hotfix-3.5.1from
umar456:pthread_fix

Conversation

@umar456

@umar456 umar456 commented Jul 17, 2017

Copy link
Copy Markdown
Member

Fixes #1856

@umar456
umar456 changed the base branch from devel to hotfix-3.5.1 July 17, 2017 23:11
@pavanky

pavanky commented Jul 17, 2017

Copy link
Copy Markdown
Member

Shouldn't the CUDA backend also be linked with the threading library ? We can not compile CUDA with gcc 7 at the moment, but it would be nice if we can fix it before it breaks in the future.

@umar456

umar456 commented Jul 17, 2017

Copy link
Copy Markdown
Member Author

I thought it was only an issue when linking with lapacke. That library is only required for the CPU and OpenCL backends.

@pavanky

pavanky commented Jul 17, 2017 •

Copy link
Copy Markdown
Member

@umar456 it is only manifesting when linking with lapacke because certain lapacke packages were providing the missing symbol through indirect linkage.

pthread_create is still found in libafcuda.so

$ nm -C ~/Workspace/local/lib/libafcuda.so.3.5.0  | grep pthread_create
                 U pthread_create@@GLIBC_2.2.5

@umar456
umar456 merged commit 818d674 into arrayfire:hotfix-3.5.1 Jul 19, 2017
umar456 added a commit to umar456/arrayfire that referenced this pull request Aug 18, 2017
* Fix pthreads linking error when linking with lapacke

* Add pthreads always
@mlloreda mlloreda added this to the v3.5.1 milestone Aug 18, 2017
umar456 added a commit to umar456/arrayfire that referenced this pull request Aug 18, 2017
* Fix pthreads linking error when linking with lapacke

* Add pthreads always
@umar456
umar456 deleted the pthread_fix branch August 23, 2017 13:56
pavanky pushed a commit that referenced this pull request Aug 23, 2017
* Fix pthreads linking error when linking with lapacke

* Add pthreads always
@mlloreda mlloreda mentioned this pull request Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants