Repository navigation
Handle empty arrays in a variety of functions - #1533
Merged
Merged
Conversation
|
|
||
| if(rhsDims.ndims() == 0) { | ||
| dim_t my_dims[] = { 0, 0, 0, 0 }; | ||
| return af_create_handle(out, AF_MAX_DIMS, my_dims, rhsType); |
Member
There was a problem hiding this comment.
This is incorrect. We should check if both rhs and index are empty and then return a retained version of lhs.
Member
There was a problem hiding this comment.
If lhs is empty, then return the way you did here.
Member
|
May I suggest tests for all of these? |
syurkevi
force-pushed
the
zero_len
branch
2 times, most recently
from
August 4, 2016 23:33
d074549 to
d001252
Compare
allow indexing with empty arrays
Member
|
build arrayfire linux ci |
Member
|
build arrayfire linux ci |
Member
|
build arrayfire windows ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows indexing with empty arrays . Also handles weird cases such as
af::det( [ ] ) = 1