Disable CPU Async if GCC Version is less than 4.8.4#1380
Merged
Conversation
Member
Author
|
In the current code, if the compiler is older than 4.8.4, then there is no way to compile it for Async also (cant force it either since the option itself is entirely removed). This would cause a lot of problems.
I think the first option is more clean. |
User can still set it on in CMake
Member
Author
|
Fixed the last comment. CMake will turn off the async variable if an older compiler is detected, but user can set it to on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]
Fixes #1378