Skip to content

Changes to get device on which an array was created.#1299

Merged
pavanky merged 4 commits into
arrayfire:develfrom
pavanky:device_id
Feb 24, 2016
Merged

Changes to get device on which an array was created.#1299
pavanky merged 4 commits into
arrayfire:develfrom
pavanky:device_id

Conversation

@pavanky
Copy link
Copy Markdown
Member

@pavanky pavanky commented Feb 23, 2016

@pavanky pavanky added this to the 3.3.0 milestone Feb 23, 2016
- device id now occupies the last 8 bits.
@pavanky pavanky changed the title Changes to get devie on which an array was created. Changes to get device on which an array was created. Feb 24, 2016
@shehzan10
Copy link
Copy Markdown
Member

build arrayfire windows ci

Comment thread test/array.cpp Outdated
{
if (getDeviceCount() < 2) return;
array a = randu(5,5);
ASSERT_EQ(getDeviceId(a), 0);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be asserted without doing an explicit setDevice. It is possible to run tests on other devices.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll fix this.

pavanky added a commit that referenced this pull request Feb 24, 2016
Changes to get device on which an array was created.
@pavanky pavanky merged commit c6f8a90 into arrayfire:devel Feb 24, 2016
@pavanky pavanky deleted the device_id branch February 24, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants