Added Homography#1085
Merged
Merged
Conversation
added 10 commits
November 3, 2015 14:37
Will be re-enabled when static test data is generated, thus reducing discrepancies between different backends.
Member
There was a problem hiding this comment.
Can you wrap this into multiple lines. Same with the C-api
Member
Author
|
build arrayfire osx ci |
Member
There was a problem hiding this comment.
Modify the name to AF_HOMOGRAPHY_[RANSAC, LMEDS]
Member
Author
|
[skip ci] |
Member
There was a problem hiding this comment.
outis not a parameter name- flip the order of
htype,inlier_thranditerationsto match the function parameter order - change
af_homography_typetohtypein the documentation - change
type/dtypetootype
Member
There was a problem hiding this comment.
I don't think these are necessary
Member
Author
There was a problem hiding this comment.
They may not be necessary here but it is safer and follows closely the OpenCL code, plus, this won't make too much of a difference in performance.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]