Skip to content

Adapts to new Boost download location - #15691

Merged
clonker merged 1 commit into
developfrom
boost_download_location
Jan 6, 2025
Merged

clonker merged 1 commit into
developfrom
boost_download_location

Conversation

@clonker

@clonker clonker commented Jan 6, 2025 •

Copy link
Copy Markdown
Member

Fixes #15690

PR switching to the new emscripten docker file: #15693

@clonker
clonker force-pushed the boost_download_location branch from b07d539 to ac4d267 Compare January 6, 2025 10:36
@clonker
clonker requested a review from r0qs January 6, 2025 10:47
@github-actions

github-actions Bot commented Jan 6, 2025

Copy link
Copy Markdown

solbuildpackpusher/solidity-buildpack-deps:emscripten-20 [solbuildpackpusher/solidity-buildpack-deps@sha256:98f963ed799a0d206ef8e7b5475f847e0dea53b7fdea9618bbc6106a62730bd2].

@ekpyron ekpyron left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a PR switching to the new docker file (and look at tests there to proceed with merging here)

We can keep ignoring the ossfuzz image for now, since IIRC it'll be separately fixed.

I'm not approving, since I don't see the sibling PR switching the image hashes for CI yet (if there is one, link it in the description)

@ekpyron ekpyron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approving this (even though it's technically not the correct sequence of changes), since the emscripten build in #15691 passed (we should wait for the tests with merging it, though).

Not sure if we should even touch the ossfuzz image here, but I guess better to avoid confusion about the URL here when finally fixing it properly, so fine with keeping the change here, even though we can't build the image.

@clonker
clonker merged commit 9aff769 into develop Jan 6, 2025
@clonker
clonker deleted the boost_download_location branch January 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downloaded Boost source package failed

2 participants