fix(client): improve support of deepObject query serialization method#517
Merged
Conversation
Owner
|
Thanks @mezannic ! |
Contributor
Author
|
@ardatan Thank you for the fix! I see you had to update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
Client - Deep objects are sent as empty string in query parameters.
This makes the client unsuitable for use with JSON:API sparse fieldsets
Related #516
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Running the test will perform a query to https://postman-echo.com/ to assert that the request sent by the client contains the expected query parameters.
Test Environment:
package-name: fetsChecklist:
CONTRIBUTING doc and the
style guidelines of this project
-> No changeset generated yet
-> GitHub Codespaces shows a linting error in my test file, I don't now why
-> I am not aware of any downstream module which would be affected by this
Further comments
This change, albeit small, is a breaking change: people who would expect objects to be stripped from the query parameters sent by the client will now see them sent to the server. I won't probably cause any issue, but…