Skip to content

fix(client-oas): default should exclude defined status codes#486

Merged
ardatan merged 1 commit into
masterfrom
fets-default-status
Aug 22, 2023
Merged

fix(client-oas): default should exclude defined status codes#486
ardatan merged 1 commit into
masterfrom
fets-default-status

Conversation

@ardatan

@ardatan ardatan commented Aug 22, 2023

Copy link
Copy Markdown
Owner

Fixes #479

@ardatan ardatan marked this pull request as ready for review August 22, 2023 14:26
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
fets 0.4.12-alpha-20230822142754-0c14bd1 npm ↗︎ unpkg ↗︎

@github-actions

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://857bc626.fets.pages.dev

@github-actions

Copy link
Copy Markdown
Contributor

✅ Benchmark Results

     ✓ no_errors{server:node-http,mode:no-schema}
     ✓ expected_result{server:node-http,mode:no-schema}
     ✓ no_errors{server:node-http,mode:json-schema}
     ✓ expected_result{server:node-http,mode:json-schema}
     ✓ no_errors{server:node-http,mode:zod}
     ✓ expected_result{server:node-http,mode:zod}
     ✓ no_errors{server:uWebSockets,mode:no-schema}
     ✓ expected_result{server:uWebSockets,mode:no-schema}
     ✓ no_errors{server:uWebSockets,mode:json-schema}
     ✓ expected_result{server:uWebSockets,mode:json-schema}
     ✓ no_errors{server:uWebSockets,mode:zod}
     ✓ expected_result{server:uWebSockets,mode:zod}

     checks......................................: 100.00% ✓ 1459518     ✗ 0     
     data_received...............................: 140 MB  776 kB/s
     data_sent...................................: 91 MB   505 kB/s
     http_req_blocked............................: avg=1.17µs   min=700ns   med=1µs      max=523.5µs p(90)=1.4µs    p(95)=1.7µs  
     http_req_connecting.........................: avg=0ns      min=0s      med=0s       max=184.7µs p(90)=0s       p(95)=0s     
     http_req_duration...........................: avg=174.13µs min=96.9µs  med=154.7µs  max=17.35ms p(90)=191.5µs  p(95)=212.2µs
       { expected_response:true }................: avg=174.13µs min=96.9µs  med=154.7µs  max=17.35ms p(90)=191.5µs  p(95)=212.2µs
     ✓ { server:node-http,mode:json-schema }.....: avg=183.25µs min=120.9µs med=167.3µs  max=15.12ms p(90)=202µs    p(95)=223.8µs
     ✓ { server:node-http,mode:no-schema }.......: avg=177.47µs min=110.7µs med=155.2µs  max=17.3ms  p(90)=199.4µs  p(95)=217.5µs
     ✓ { server:node-http,mode:zod }.............: avg=178.79µs min=121.6µs med=168µs    max=11.75ms p(90)=197.5µs  p(95)=216.4µs
     ✓ { server:uWebSockets,mode:json-schema }...: avg=172.78µs min=105.2µs med=149.69µs max=17.35ms p(90)=178.7µs  p(95)=198.5µs
     ✓ { server:uWebSockets,mode:no-schema }.....: avg=159.45µs min=96.9µs  med=139.6µs  max=16.53ms p(90)=171.6µs  p(95)=194µs  
     ✓ { server:uWebSockets,mode:zod }...........: avg=174.64µs min=111.1µs med=154.5µs  max=14.73ms p(90)=186.1µs  p(95)=214.3µs
     http_req_failed.............................: 0.00%   ✓ 0           ✗ 729759
     http_req_receiving..........................: avg=17µs     min=9.6µs   med=14.4µs   max=8.86ms  p(90)=21.6µs   p(95)=26.3µs 
     http_req_sending............................: avg=6.78µs   min=3.8µs   med=5.6µs    max=10.92ms p(90)=8.1µs    p(95)=10.7µs 
     http_req_tls_handshaking....................: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s     
     http_req_waiting............................: avg=150.34µs min=78.2µs  med=133.39µs max=17.09ms p(90)=164.39µs p(95)=182.3µs
     http_reqs...................................: 729759  4054.159292/s
     iteration_duration..........................: avg=241.85µs min=161.1µs med=219µs    max=17.73ms p(90)=269.2µs  p(95)=294.2µs
     iterations..................................: 729759  4054.159292/s
     vus.........................................: 1       min=1         max=1   
     vus_max.....................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

status in OASResponse is 200 | NotOkStatusCode, should be derived from the schema

1 participant