Repository navigation
fix(chat): start without a screen for the tab status - #16
Merged
Merged
Conversation
runChat resets the session before it makes the screen, and the reset cleared the tab status through the nil screen: every chat panicked on start in v1.10.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
v1.10.0 panics as soon as the chat starts:
runChatcallsreset()before it creates the screen, andreset()now clears the tab status throughs.scr, which is still nil at that point. One-shot questions (docsgpt-cli "…") are unaffected.Fix
tabStatusreturns when there is no screen yet: nothing can be shown on the tab before then.Testing
TestResetBeforeScreen: panics without the fix, passes with it.gofmt -l .,go vet ./...,go test ./...HOME: the v1.10.0 code panics, this branch brings up the chat screen.