chore: trigger release workflow on tag push instead of release published#12759
chore: trigger release workflow on tag push instead of release published#12759hardikkaurani wants to merge 2 commits into
Conversation
Greptile SummarySwitches the release workflow trigger from
Confidence Score: 5/5Safe to merge — the change is a minimal, well-scoped trigger swap that does not alter any build, push, or deployment logic. The only change is the workflow trigger: No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "chore: restrict tag trigger to digit-bas..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions Release workflow trigger so that Docker multi-platform release builds run when a SemVer tag is pushed (instead of when a GitHub Release is published), enabling maintainers to validate artifacts before publishing the GitHub Release and avoiding duplicate watcher notifications.
Changes:
- Switch
.github/workflows/release.ymltrigger fromrelease.publishedtopushon tag patterns. - Align release build triggering closer to the existing tag-driven cloud image pipeline behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| on: | ||
| release: | ||
| types: [published] | ||
| push: | ||
| tags: | ||
| - '*.*.*' |
Summary
This PR addresses issue #12753 where the release tag
1.9.5had to be deleted, recreated, and republished several times to include hotfixes. Each time a release was republished on GitHub, watchers received duplicate notifications, and the release tags pointed to mutable commits during the transition.Changes
Releaseworkflow (.github/workflows/release.yml) to trigger on a semver tag push event (*.*.*) rather than therelease: publishedevent.publish.yml) handles tag-based building.Closes #12753