Skip to content

fix(locale): add missing sessionAlert translations for Spanish#11775

Open
ashstrc wants to merge 2 commits intoappwrite:1.9.xfrom
ashstrc:1.9.x
Open

fix(locale): add missing sessionAlert translations for Spanish#11775
ashstrc wants to merge 2 commits intoappwrite:1.9.xfrom
ashstrc:1.9.x

Conversation

@ashstrc
Copy link
Copy Markdown

@ashstrc ashstrc commented Apr 3, 2026

What does this PR do?

This PR adds missing emails.sessionAlert.* translations to the Spanish (es.json) locale.

Previously, these keys were not defined, causing raw template placeholders like {{emails.sessionAlert.subject}} to appear in emails instead of proper localized content.


Why is this needed?

The absence of sessionAlert translations in the Spanish locale leads to broken email rendering for session alerts. This results in a poor user experience and inconsistent localization behavior.


Changes made

  • Added missing emails.sessionAlert.* keys to es.json
  • Ensured consistency with the en.json structure
  • Fixed minor formatting inconsistencies (e.g., punctuation and variable usage)

Test Plan

  • Verified that all emails.sessionAlert.* keys are now present in es.json
  • Ensured placeholders are correctly replaced in email templates
  • Confirmed consistency with the English (en.json) reference

Related Issues

Fixes #8659


Checklist

  • I have read the contributing guidelines
  • This change does not affect runtime logic (docs/locale only)
  • Translations match the structure of en.json

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 3, 2026

Greptile Summary

This PR adds missing emails.sessionAlert.* translation keys to the Spanish locale (es.json), fixing a bug where session alert emails would render raw template placeholders for Spanish-speaking users. It also updates {{name}} to {{user}} in the verification and recovery email keys to match the current en.json template variables.

Key findings:

  • The newly added emails.sessionAlert.body value contains a duplicated sentence — Aquí están los detalles: appears twice at the end of the string (should appear only once, as in the English source).
  • Bold formatting tags ({{b}}...{{/b}}) are correctly applied in all sessionAlert keys.
  • The entire file was reformatted from 4-space to 2-space indentation, diverging from en.json and other locale files in the repository.

Confidence Score: 4/5

Mostly safe, but the duplicate sentence in the email body is a visible user-facing defect that should be fixed before merging.

One P1 issue — a duplicated sentence in emails.sessionAlert.body — will result in Spanish users seeing 'Aquí están los detalles:' printed twice in the session alert email. This is a functional correctness issue in the primary purpose of the PR. The P2 indentation inconsistency is non-blocking.

app/config/locale/translations/es.json — specifically line 34 (emails.sessionAlert.body)

Important Files Changed

Filename Overview
app/config/locale/translations/es.json Adds missing emails.sessionAlert.* translation keys for Spanish; bold formatting tags are correctly included, but emails.sessionAlert.body contains a duplicated sentence, and the entire file was re-indented from 4-space to 2-space (inconsistent with other locale files).

Reviews (2): Last reviewed commit: "fix(locale): add missing bold formatting..." | Re-trigger Greptile

Comment thread app/config/locale/translations/es.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Session Alert template broken for all languages except English

1 participant