Add nullable validator for name parameter in CreateUser endpoints#11758
Open
sashank-27 wants to merge 2 commits intoappwrite:1.9.xfrom
Open
Add nullable validator for name parameter in CreateUser endpoints#11758sashank-27 wants to merge 2 commits intoappwrite:1.9.xfrom
sashank-27 wants to merge 2 commits intoappwrite:1.9.xfrom
Conversation
…endpoints This fix addresses issue appwrite#8785 where all Users.CreateUser endpoints returned a vague server error when null was provided for the name parameter. Changes: - Changed name parameter from 'new Text(128)' to 'new Nullable(new Text(128))' in: - POST /v1/users - POST /v1/users/bcrypt - POST /v1/users/md5 - POST /v1/users/argon2 - POST /v1/users/sha - POST /v1/users/phpass - POST /v1/users/scrypt This allows the name parameter to accept null values, consistent with other optional parameters like email and phone.
Contributor
Greptile SummaryThis PR fixes a vague server error (#8785) that occurred when Key observations:
Confidence Score: 5/5
Important Files Changed
Reviews (2): Last reviewed commit: "fix: add nullable validator to user name..." | Re-trigger Greptile |
… CreateUser endpoint This completes the fix for issue appwrite#8785 by adding the Nullable wrapper to the scrypt-modified endpoint that was missed in the initial commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endpoints
This fix addresses issue #8785 where all Users.CreateUser endpoints returned a vague server error when null was provided for the name parameter.
Changes:
This allows the name parameter to accept null values, consistent with other optional parameters like email and phone.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist