fix(core): omit notifyOnNetworkStatusChange from executeQuery#337
Merged
bennypowers merged 2 commits intoJul 20, 2026
Conversation
Apollo Client 4's `client.query()` rejects `notifyOnNetworkStatusChange` with an InvariantError -- the option only applies to `watchQuery()`. The `executeQuery()` path was forwarding it unconditionally, breaking any controller using `noAutoSubscribe` + `executeQuery()`. Fixes #334 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 662dd06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for apollo-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for apollo-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifyOnNetworkStatusChangefromexecuteQuery()'sclient.query()callclient.query()with an InvariantError -- it only applies towatchQuery()Context
The 3.0.0 release added
notifyOnNetworkStatusChange: this.options.notifyOnNetworkStatusChange ?? trueto three call sites. Two are correct (watchQuery()andsubscribe()both hitclient.watchQuery()). The third is inexecuteQuery(), which callsclient.query()-- where AC4 throws.Any controller using
noAutoSubscribe+executeQuery()hits this immediately.Test plan
notifyOnNetworkStatusChangeis not a property ofclient.query()argsFixes #334