Repository navigation
Conversation
AllocateWorkspace previously revisited functions from the original module after replacing workspace-using globals. Nested generated functions could therefore retain calls to removed GlobalVars. Revisit functions from the builder context and reuse the generated workspace parameter when rewriting them. Add a regression test for nested codegen and composite functions.
tandede
force-pushed
the
fix/allocate-workspace-nested-global-var
branch
from
October 13, 2026 03:08
19ba404 to
5807330
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20614.
AllocateWorkspacepreviously revisited functions from the original module after replacing workspace-using globals. A generated workspace caller could therefore retain a call to a removedGlobalVarwhen codegen and composite functions were nested.This change revisits functions from the updated builder module and reuses the generated workspace parameter while rewriting those functions. It also adds a regression test covering nested codegen and composite functions.
Tests run locally:
cmake --build build-issue20614 --parallel 8pytest -q tests/python/relax/test_transform_allocate_workspace.pypre-commit run --files src/relax/transform/allocate_workspace.cc tests/python/relax/test_transform_allocate_workspace.py