Skip to content

Fix the abuse_shield connection flood race - #13854

Open
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:abuse-shield-flood-race
Open

bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:abuse-shield-flood-race

Conversation

@bneradt

@bneradt bneradt commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The connection flood opened idle TLS connections, but ATS runs
TS_VCONN_START only once a new connection becomes readable, so the
plugin saw each one only when the client closed it. The counter check
that follows raced that processing and read zeros on fast CI runners.

The client now sends a ClientHello on every connection, waits for ATS
to answer or refuse each one, and then confirms a connection from the
blocked IP is refused, so the counters are settled when read.

🤖 Generated with Claude Code

The connection flood opened idle TLS connections, but ATS runs
TS_VCONN_START only once a new connection becomes readable, so the
plugin saw each one only when the client closed it. The counter check
that follows raced that processing and read zeros on fast CI runners.

The client now sends a ClientHello on every connection, waits for ATS
to answer or refuse each one, and then confirms a connection from the
blocked IP is refused, so the counters are settled when read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bneradt bneradt self-assigned this Oct 16, 2026
@bneradt bneradt added this to the 11.0.0 milestone Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abuse_shield abuse shield plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants