Skip to content

feat: Adding limiting_factor column to Query model #14234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
betodealmeida merged 2 commits into from
Apr 29, 2021
Merged

feat: Adding limiting_factor column to Query model #14234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9586eb
add limiting factor to query model
AAfghahi Apr 19, 2021
9db249b
varchar instead of enum
AAfghahi Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
varchar instead of enum
  • Loading branch information
@AAfghahi
AAfghahi committed Apr 27, 2021
commit 9db249b1f3753d45ddea21b50a1824aca95f5259
32 changes: 1 addition & 31 deletions superset/migrations/versions/d416d0d715cc_add_limiting_factor_column_to_query_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,47 +26,17 @@
revision = "d416d0d715cc"
down_revision = "19e978e1b9c3"

from enum import Enum

import sqlalchemy as sa
from alembic import op
from sqlalchemy.dialects import postgresql
from sqlalchemy.dialects.postgresql.base import PGDialect

limiting_factor = postgresql.ENUM(
"DROPDOWN",
"QUERY",
"NOT_LIMITED",
"QUERY_AND_DROPDOWN",
"UNKNOWN",
name="limitingfactor",
)


def upgrade():
bind = op.get_bind()
if isinstance(bind.dialect, PGDialect):
limiting_factor.create(bind)
with op.batch_alter_table("query") as batch_op:
batch_op.add_column(
sa.Column(
"limiting_factor",
sa.Enum(
"DROPDOWN",
"QUERY",
"NOT_LIMITED",
"QUERY_AND_DROPDOWN",
"UNKNOWN",
name="limitingfactor",
),
server_default="UNKNOWN",
)
sa.Column("limiting_factor", sa.VARCHAR(255), server_default="UNKNOWN",)
)


def downgrade():
with op.batch_alter_table("query") as batch_op:
batch_op.drop_column("limiting_factor")
bind = op.get_bind()
if isinstance(bind.dialect, PGDialect):
limiting_factor.drop(bind)