Skip to content

[ISSUE #9416] Fix batch send messages have the same message id when consumed - #9417

Merged
lizhimins merged 2 commits into
apache:developfrom
qianye1001:issue9416
May 21, 2025
Merged

lizhimins merged 2 commits into
apache:developfrom
qianye1001:issue9416

Conversation

@qianye1001

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9416

Brief Description

How Did You Test This Change?

@guyinyou guyinyou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.90%. Comparing base (46b7a98) to head (c1e0107).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9417      +/-   ##
=============================================
- Coverage      47.90%   47.90%   -0.01%     
+ Complexity     11898    11897       -1     
=============================================
  Files           1307     1307              
  Lines          92033    92020      -13     
  Branches       11781    11775       -6     
=============================================
- Hits           44090    44083       -7     
- Misses         42449    42451       +2     
+ Partials        5494     5486       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earliest implementation of this was introduced through this issue. Let's see if we need to add a switch to ensure compatibility.

@lizhimins
lizhimins merged commit e1021ec into apache:develop May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Batch send messages will have the same message id when consumed

5 participants