Skip to content

[ISSUE #7029] Add a config to determine whether pop response should return the actual retry topic or tamper with the original topic - #7030

Merged
lizhimins merged 1 commit into
apache:developfrom
RongtongJin:add-swicth
Jul 18, 2023
Merged

lizhimins merged 1 commit into
apache:developfrom
RongtongJin:add-swicth

Conversation

@RongtongJin

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #7029

Brief Description

Add a config to determine whether pop response should return the actual retry topic or tamper with the original topic

How Did You Test This Change?

…al retry topic or tamper with the original topic
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #7030 (d43813a) into develop (5914ff8) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             develop    #7030   +/-   ##
==========================================
  Coverage      42.64%   42.65%           
- Complexity      9234     9241    +7     
==========================================
  Files           1136     1136           
  Lines          80646    80650    +4     
  Branches       10539    10539           
==========================================
+ Hits           34393    34398    +5     
  Misses         41962    41962           
+ Partials        4291     4290    -1     
Impacted Files Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 45.56% <0.00%> (+0.61%) ⬆️
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.28% <25.00%> (-0.02%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins
lizhimins merged commit 737c1e5 into apache:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a config to determine whether pop response should return the actual retry topic or tamper with the original topic

5 participants