[improve][client] Adding support for token supplier for the AuthenticationToken#395
Merged
Conversation
Contributor
Author
|
@shibd Hi :), |
shibd
reviewed
Oct 18, 2024
shibd
left a comment
Member
There was a problem hiding this comment.
Great work! Left some small comments.
… auth; Clean code
Contributor
|
Great stuff, I'd love to see this feature released in 1.13.0! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #396
Motivation
The
AuthenticationTokenonly supports static token, limiting us to use token without expiration.So the integration with existing authentication returns tokens with expiration becomes not possible.
Modifications
Added the necessary cpp code for support token supplier as a js callback returns string tokens.
Modified file:
index.d.ts- Update constructor signature for support TS.src/Authentication.cc- Implement the logic of communication between js callback and cpp token supplier.New file
-
src/TokenSupplier.h- Needed for the logic implementation.-
examples/consummer_token.js- ExampleVerifying this change
This change added tests and can be verified as follows:
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededThe changes is internally only, the feature is already documented.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)