Repository navigation
Attempting to fix issues with printing - #135
Open
trumpetinc wants to merge 5 commits into
Open
trumpetinc wants to merge 5 commits into
trumpetinc wants to merge 5 commits into
Conversation
added 5 commits
November 7, 2021 11:10
Contributor
|
Why did you change the equals and the hash, is this for optimizing? (Assumption that xform is only scale, never shear) I tried the scale change from your last commit, this does not work well when setting MAXEDGE at 500. The "Schleuse" file looks very different. The problem is that the pattern gets shorter and is scaled so the repetition is visible, while a crop has no effect as long as the cropped part is outside the page. This can also be seen on page 7 of the file from PDFBOX-3653.pdf . |
Author
|
Yes - it is an optimization. I'm pretty sure you can re-use the cached
value if there is only a translation. But please sanity check my logic on
this.
This is not the most important optimization for printing - by far the most
important optimization is caching of the PageDrawer.
And switching to the weak *valued* cache in TilingPatternFactory is
important as the current cache is going to evict very rapidly.
- K
Kevin Day
*trumpet**p| *480.961.6003 x1002
*e| ***@***.***
www.trumpetinc.com <http://trumpetinc.com/>
LinkedIn <https://www.linkedin.com/company/trumpet-inc.>| Trumpet Blog
<http://trumpetinc.com/blog/>| Twitter <https://twitter.com/trumpetinc>
Proud to be Great Place To Work
<https://www.greatplacetowork.com/certified-company/7012667> certified
since 2019
…On Tue, Nov 9, 2021 at 11:06 AM Tilman Hausherr ***@***.***> wrote:
Why did you change the equals and the hash, is this for optimizing?
(Assumption that xform is only scale, never shear)
I tried the scale change from your last commit, this does not work well
when setting MAXEDGE at 500. The "Schleuse" file looks very different. The
problem is that the pattern gets shorter and is scaled so the repetition is
visible, while a crop has no effect as long as the cropped part is outside
the page. This can also be seen on page 7 of the file from PDFBOX-3653.pdf .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#135 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSP46ECLJQIO6YVMXBUZSDULFPKRANCNFSM5HRCREUQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see "Guidance on heap space error when printing document" discussion on user listserv