fix(commit): allow disabled manifest delete stats option - #187
Merged
SteNicholas merged 1 commit intoAug 6, 2026
Merged
Conversation
Parse manifest.delete-file-drop-stats and reject it only when enabled, because false matches the existing C++ commit behavior. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 8/8 AI-Contributed/UT: 6/6
liujiayi771
marked this pull request as ready for review
August 6, 2026 02:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow the C++ commit path to accept
manifest.delete-file-drop-stats=false. The disabled value matches the existing C++ behavior, which preserves statistics in DELETE manifest entries. The enabled value remains unsupported and rejected.Tests
./build-release/release/paimon-core-test --gtest_filter='FileStoreCommitImplTest.ValidateCommitOptionsAllowsDisabledManifestDeleteFileDropStats:FileStoreCommitImplTest.ValidateCommitOptionsRejectsUnsupportedOptions'./build-release/release/paimon-core-test --gtest_brief=1(1579 tests passed)pre-commit run --files src/paimon/core/operation/file_store_commit_impl.cpp src/paimon/core/operation/file_store_commit_impl_test.cppAPI and Format
No public API, storage format, or protocol changes.
Documentation
No documentation changes. This fixes validation of an existing option.
Generative AI tooling
Generated-by: Codex, GPT-5.