Skip to content

NIFI-15785 - Update parameter and parameter context descriptions during versioned flow upgrade#11096

Merged
exceptionfactory merged 3 commits intoapache:mainfrom
pvillard31:NIFI-15785
Apr 9, 2026
Merged

NIFI-15785 - Update parameter and parameter context descriptions during versioned flow upgrade#11096
exceptionfactory merged 3 commits intoapache:mainfrom
pvillard31:NIFI-15785

Conversation

@pvillard31
Copy link
Copy Markdown
Contributor

@pvillard31 pvillard31 commented Apr 2, 2026

Summary

NIFI-15785 - Update parameter and parameter context descriptions during versioned flow upgrade

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory requested changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvillard31, the functional changes look good. I noticed the a number of repeated values in the tests, including things like description strings where the value is being asserted. Pulling these out to class level or method level variables would be helpful for maintainability.

@pvillard31
Copy link
Copy Markdown
Contributor Author

pvillard31 commented Apr 3, 2026

Thanks for the review @exceptionfactory - I did some cleanup as suggested. I could go further with the strings like "abc", "param1", etc, but that would be touching all of the test class. Let me know if this should be done.

@pvillard31
NIFI-15785 - review
327d3e5 
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
exceptionfactory
exceptionfactory reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvillard31, it looks like it would be helpful to declare some static Maps for reusable parameter names and values where applicable.

exceptionfactory
exceptionfactory approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvillard31! +1 merging

@exceptionfactory exceptionfactory merged commit 87e65db into apache:main Apr 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pvillard31 @exceptionfactory