Convert FileFormatModel from ABC to typing.Protocol#3692
Open
nssalian wants to merge 1 commit into
Open
Conversation
nssalian
marked this pull request as ready for review
July 23, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3100
Rationale for this change
FileFormatModelhad only abstract methods (no shared implementation), so anABCwas heavier than needed. This PR converts it totyping.Protocol, which is the more Pythonic pattern for a pure interface.FileFormatWriterremains anABCsince it has shared__enter__/__exit__/resultimplementations that inheritance carries for free.FileFormatFactoryis unchanged - it matches the existingAuthManagerFactorypattern.Changes
New format implementations can now conform structurally without inheriting from
FileFormatModel. Net: 2ABCs → 1ABC+ 1Protocol. No signature change for existing callers;ParquetFormatModel(FileFormatModel)inheritance is retained (Protocolsupports explicit conformance).Are these changes tested?
Yes.
tests/io/test_fileformat.pyadds two tests using a shared_StructuralModelhelper:test_file_format_model_is_protocol- a structurally-conforming class (no inheritance) passesisinstance()againstFileFormatModel.test_structural_model_works_with_factory- a structurally-conforming class can be registered and retrieved viaFileFormatFactoryend-to-end.Are there any user-facing changes?
No. Default behavior is unchanged.