Skip to content

Build: Bump hadoop from 3.4.3 to 3.5.0.#15897

Open
slfan1989 wants to merge 1 commit intoapache:mainfrom
slfan1989:bump-hadoop-from-3.4.3-to-3.5.0
Open

Build: Bump hadoop from 3.4.3 to 3.5.0.#15897
slfan1989 wants to merge 1 commit intoapache:mainfrom
slfan1989:bump-hadoop-from-3.4.3-to-3.5.0

Conversation

@slfan1989
Copy link
Copy Markdown
Contributor

Build: Bump hadoop from 3.4.3 to 3.5.0.

@slfan1989 slfan1989 marked this pull request as draft April 6, 2026 12:15
@slfan1989 slfan1989 force-pushed the bump-hadoop-from-3.4.3-to-3.5.0 branch from afa9bc6 to f94972f Compare April 12, 2026 12:57
@github-actions github-actions Bot added the spark label Apr 12, 2026
@slfan1989 slfan1989 force-pushed the bump-hadoop-from-3.4.3-to-3.5.0 branch from 58516fe to aa181ac Compare April 13, 2026 02:15
@slfan1989 slfan1989 marked this pull request as ready for review April 13, 2026 02:16
@slfan1989
Copy link
Copy Markdown
Contributor Author

@nastra @huaxingao Could you help review this PR? Thank you very much! This change is mainly to support the newly released Hadoop version(hadoop-3.5.0), which is the first version with full JDK 17 support. Compared with hadoop-3.4.3, it upgrades Jersey to 2.46 and introduces related Jakarta dependency changes, including the switch to jakarta.servlet.jsp-api. Therefore, we need to explicitly add the javax.servlet:javax.servlet-api:4.0.1 dependency in Spark 3.4 and Spark 3.5.

Comment thread gradle/libs.versions.toml
jackson215 = { strictly = "2.15.2"} # see rich version usage explanation above
jakarta-el-api = "3.0.3"
jakarta-servlet-api = "6.1.0"
javax-servlet-api = "4.0.1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR mentions that Hadoop is being bumped, but that change is missing here

Comment thread gradle/libs.versions.toml
jetty-compression-server = { module = "org.eclipse.jetty.compression:jetty-compression-server", version.ref = "jetty" }
jetty-compression-gzip = { module = "org.eclipse.jetty.compression:jetty-compression-gzip", version.ref = "jetty" }
javax-servlet = { module = "javax.servlet:javax.servlet-api", version.ref = "javax-servlet-api" }
jetty-server = { module = "org.eclipse.jetty:jetty-server", version.ref = "jetty" }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be needed, because we're using jetty-compression-server already

Comment thread gradle/libs.versions.toml
jakarta-servlet = {module = "jakarta.servlet:jakarta.servlet-api", version.ref = "jakarta-servlet-api"}
jetty-compression-server = { module = "org.eclipse.jetty.compression:jetty-compression-server", version.ref = "jetty" }
jetty-compression-gzip = { module = "org.eclipse.jetty.compression:jetty-compression-gzip", version.ref = "jetty" }
javax-servlet = { module = "javax.servlet:javax.servlet-api", version.ref = "javax-servlet-api" }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javax-servlet is deprecated and was replaced by jakarta-servlet. Is this something that we can use here instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants