Repository navigation
Core: Allow adding files to multiple partition specs in FastAppend - #11771
Merged
Merged
Conversation
Collaborator
Author
|
@aokolnychyi @stevenzwu - Could you please take a look? |
anuragmantri
marked this pull request as draft
December 13, 2024 00:44
anuragmantri
force-pushed
the
fast-appen-multi-part
branch
from
December 16, 2024 23:34
41e5fde to
8422e26
Compare
anuragmantri
marked this pull request as ready for review
December 16, 2024 23:34
anuragmantri
commented
Dec 16, 2024
| replaceSortOrder.commit(); | ||
|
|
||
| // Get new spec after commit to write new file with new spec | ||
| PartitionSpec newSpec = create.table().spec(); |
Collaborator
Author
There was a problem hiding this comment.
This test was not using the latest spec. I would fail with newAppend() too.
aokolnychyi
approved these changes
Jan 10, 2025
Contributor
|
Thanks, @anuragmantri! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ability to add files to multiple partition specs in FastAppend. Inspired by MergeAppend code.