Repository navigation
core: Ignore If-Modified-Since and If-Unmodified-Since without a modification date. - #862
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…fication date. For a resource with no modification date, like a CGI script which sends no Last-Modified, ap_condition_if_modified_since() and ap_condition_if_unmodified_since() compared the request with the current time, so such a request could get a wrong 304 or 412. RFC 9110 sections 13.1.3 and 13.1.4 say to ignore the condition in that case. PR 39287.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a resource has no modification date (a CGI script that sends no Last-Modified, for example),
ap_condition_if_modified_since()andap_condition_if_unmodified_since()used the current time as its date. So a request with an If-Modified-Since of the current second got a 304, and any If-Unmodified-Since in the past got a 412, for content that has no date at all.RFC 9110 13.1.3 and 13.1.4 say a recipient MUST ignore these headers if the resource does not have a modification date available. This does that: without a valid Last-Modified and without r->mtime the condition is ignored.
This is https://bz.apache.org/bugzilla/show_bug.cgi?id=39287. The same code is in 2.4.x.
I added a test in test/modules/core with a few small CGI scripts (no Last-Modified, invalid Last-Modified, and one with a valid date as a control). Without the change 5 of the 6 tests fail, with it they all pass. I also ran test/modules/core, test/modules/http1 and the pytest_suite apache, cache, negotiation, cgi and include tests before and after, with no other difference.
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.