Repository navigation
Conversation
tcoatswo
marked this pull request as ready for review
October 12, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deferred lingering-close chain has multiple worker consumers. A worker currently loads the head, then reads
cs->chainfor its compare-and-swap. Another worker may remove and finish closing that head in between, releasing the pool that ownscsbefore the first worker reads its link.Guard insertion, removal, and the listener's scheduling snapshot with the existing
timeout_mutex. A worker now detaches the head and reads its successor while holding the same lock; it processes the detached connection after releasing the lock. This keeps the link read within the node's lifetime. There is no change to the connection's close processing after dequeue.Validation
git diff --checkpasses; the branch changes onlyserver/mpm/event/event.c.