Repository navigation
HIVE-30237: Clean up dependencies post thrift upgrade - #6938
Open
dengzhhu653 wants to merge 1 commit into
Open
dengzhhu653 wants to merge 1 commit into
dengzhhu653 wants to merge 1 commit into
Conversation
|
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.thrift</groupId> | ||
| <artifactId>libthrift</artifactId> |
Contributor
There was a problem hiding this comment.
is deletion of org.apache.thrift:libthrift intentional here?
I know it will transitively come from metastore-common so it will work but its directly used in the module?
| protected boolean isServerFilterEnabled = false; | ||
|
|
||
| // ======================== FaceBookBase =================================== | ||
| private String name_; |
Contributor
There was a problem hiding this comment.
I understand the need for 1:1 copy of FacebookBase for existing behaviour, but since this code will now be owned by Hive
- These C++ naming conventions which sonar has flagged can be flagged?
- Use CAS based increment counter?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?