[fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients#62244
Merged
luwei16 merged 3 commits intoapache:masterfrom Apr 20, 2026
Merged
[fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients#62244luwei16 merged 3 commits intoapache:masterfrom
luwei16 merged 3 commits intoapache:masterfrom
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK.
### Release note
None
### Check List (For Author)
- Test: Cloud unit test
- ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8
- Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
w41ter
previously approved these changes
Apr 8, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
previously approved these changes
Apr 8, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
### What problem does this PR solve? Issue Number: None Related PR: apache#62244 Problem Summary: Add cloud unit tests that cover the MetaServiceProxy downgrade paths for KV_TXN_MAYBE_COMMITTED so the PR's retry-handling change is exercised on both read and commit RPCs. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j8 - Behavior changed: No - Does this need documentation: No
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run nonConcurrent |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
gavinchou
approved these changes
Apr 17, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8 - Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8 - Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK.
Release note
None
Check List (For Author)
Test: Cloud unit test
Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)
Does this need documentation: No