branch-4.1:[fix](filecache) BlockFileCache use-after-free caused by destructor order (#61192)#62237
Merged
yiguolei merged 1 commit intoapache:branch-4.1from Apr 9, 2026
Conversation
…rder - In BlockFileCache::initialize_unlocked(): _storage->init(this) is executed first, then _ttl_mgr is created via raw pointer from fs_storage->get_meta_store() - Member variables order: _ttl_mgr (front), _storage (back) - C++ reverse destructor order leads to _storage being destructed before _ttl_mgr - Risk: *_ttl_mgr threads may access already-destructed _storage/_meta_store Signed-off-by: zhengyu <zhangzhengyu@selectdb.com> (cherry picked from commit 51120ba)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
skip buildall |
yiguolei
approved these changes
Apr 9, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #61192 to branch-4.1.
Original PR: #61192
No compile/test run for this pick.