Skip to content

Remove exclusions from FindBugsExcludeFilter.xml #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leerho merged 1 commit into from
Apr 9, 2025
Merged

Remove exclusions from FindBugsExcludeFilter.xml #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions tools/FindBugsExcludeFilter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,6 @@ under the License.
<Match>
<Class name="~.*\.*Test" />
</Match>

<Match>
<Class name="~.*\.*TestUtil" />
</Match>

<!-- Harmless, False Positive Mar 6, 2024. Alex may fix this. -->
<Match>
<Bug pattern="DLS_DEAD_LOCAL_STORE" />
<Class name="org.apache.datasketches.tdigest.TDigestDouble"/>
<Method name="merge" />
</Match>

<!-- Complaining about copying of arrays from one internal class to another.
This is harmless since both classes are part of our library and work together. -->
Expand All @@ -49,7 +38,8 @@ under the License.
</Or>
</Match>

<Match> <!-- False Positive: These are intentional and we know what we are doing. -->
<!-- False Positive: These are intentional and we know what we are doing. -->
<Match>
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
<Class name="org.apache.datasketches.sampling.EbppsItemsSample" />
<Or>
Expand All @@ -58,7 +48,8 @@ under the License.
</Or>
</Match>

<Match> <!-- False Positive: Code is the recommended solution for preventing a Finalizer Attack. -->
<!-- False Positive: Code is the recommended solution for preventing a Finalizer Attack. -->
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW" />
<Or>
<Class name="org.apache.datasketches.tuple.arrayofdoubles.DirectArrayOfDoublesQuickSelectSketch"/>
Expand Down