Fix SUBSTRING from/to argument construction for mssql#947
Merged
Conversation
alamb
approved these changes
Aug 17, 2023
| #[test] | ||
| fn parse_substring() { | ||
| one_statement_parses_to("SELECT SUBSTRING('1')", "SELECT SUBSTRING('1')"); | ||
| let from_for_supported_dialects = TestedDialects { |
| expr: Box::new(expr), | ||
| substring_from: from_expr.map(Box::new), | ||
| substring_for: to_expr.map(Box::new), | ||
| special: !self.dialect.supports_substring_from_for_expr(), |
Contributor
There was a problem hiding this comment.
As a minor nit hard coding this to false I think would be clearer for me:
Suggested change
| special: !self.dialect.supports_substring_from_for_expr(), | |
| special: false, |
Likewise below.
No changes are needed in this PR -- I'll make a follow on one with the proposed change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #914. This modifies the parsing of
SUBSTRINGfor dialects like MsSqlServer which doesn't support theSUBSTRING(expr [FROM start] [FOR len])syntax.