fix: merge byte string literal#834
Closed
togami2864 wants to merge 2 commits into
Closed
Conversation
Pull Request Test Coverage Report for Build 4400773307
💛 - Coveralls |
Contributor
|
@alamb do you have thoughts on changes like this? I generally agree it's probably fine to only have one type of byte string literal, and the two new types are new (2/20/23) but there's a small risk of regressing someone's existing code that distinguishes the two cases. |
Closed
Contributor
|
I don't see the harm in keeping these two variants separate -- if downstream crates want to treat them the same they can do so, and if they want to handle them separately they can with the current forumulation Thus I would not be in favor of merging this unless there is some compelling usecase |
Contributor
Author
|
That makes sense to me. I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the same as #812 (comment), quote style isn't important.
This PR merges
SingleQuotedByteStringLiteralandDoubleQuotedByteStringLiteraltoByteStringLiteral.