Skip to content

Fix cargo docs / warnings and add CI check#777

Merged
alamb merged 9 commits into
apache:mainfrom
alamb:alamb/fix_doc_links
Dec 29, 2022
Merged

Fix cargo docs / warnings and add CI check#777
alamb merged 9 commits into
apache:mainfrom
alamb:alamb/fix_doc_links

Conversation

@alamb

@alamb alamb commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

This was bothering me when working on tests / docs for visitor

Rationale:
Fix all cargo doc warning, and add CI check to avoid errors in the future

Example CI test failure: https://github.com/sqlparser-rs/sqlparser-rs/actions/runs/3795223499/jobs/6454127069

@coveralls

coveralls commented Dec 28, 2022

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3795248432

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.974%

Totals Coverage Status
Change from base Build 3795081688: 0.0%
Covered Lines: 13007
Relevant Lines: 15129

💛 - Coveralls

Comment thread src/keywords.rs

//! This module defines
//! 1) a list of constants for every keyword that
//! can appear in [Word::keyword]:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be referring to some older version of the code

@alamb alamb merged commit b93d82d into apache:main Dec 29, 2022
@alamb alamb deleted the alamb/fix_doc_links branch April 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants