Add FULLTEXT support for MySQL and Generic dialects#702
Merged
Conversation
Pull Request Test Coverage Report for Build 3424850968
💛 - Coveralls |
alamb
approved these changes
Nov 7, 2022
Comment on lines
+288
to
+290
| /// Whether the type is followed by the keyword `KEY` (Some(true)), `INDEX` (Some(false)), | ||
| /// or no keyword at all (None). | ||
| opt_key: Option<bool>, |
Contributor
There was a problem hiding this comment.
Maybe an enum would be easier to use here
enum SpatialKey {
Key,
Index,
None,
}🤔
alamb
approved these changes
Nov 9, 2022
alamb
left a comment
Contributor
There was a problem hiding this comment.
LGTM -- thanks @AugustoFKL
Comment on lines
+367
to
+369
| if !matches!(index_type_display, KeyOrIndexDisplay::None) { | ||
| write!(f, " {}", index_type_display)?; | ||
| } |
Contributor
There was a problem hiding this comment.
Since KeyOrIndexDisplay::None is displayed as "" I suspect you don't even have to have this test
Suggested change
| if !matches!(index_type_display, KeyOrIndexDisplay::None) { | |
| write!(f, " {}", index_type_display)?; | |
| } | |
| write!(f, " {}", index_type_display)?; |
Contributor
Author
There was a problem hiding this comment.
@alamb the problem is that i'd have an additional space compared to the input string. Although it isn't incorrect, IMHO would be weird to print something like:
CREATE TABLE tb (c1 TEXT, FULLTEXT (c1, c2);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add FULLTEXT (1), (2), option on create table for MySQL and Generic dialects.
[1] : https://dev.mysql.com/doc/refman/8.0/en/create-table.html
[2] : https://dev.mysql.com/doc/refman/8.0/en/fulltext-natural-language.html