Support MySQL table option {INDEX | KEY} to the CREATE TABLE, restrict to MySql and generic dialects#665
Merged
Conversation
… (partial). Theoretically the behavior should be the same as CREATE INDEX, but we cannot make that assumption, so the parse is (almost) identical as the input. Breaking changes: - Now HASH and BTREE are KEYWORDS, and using them as names can result in errors. - Now 'KEY' and 'INDEX' column names start the parsing of a table constraint if unquoted for the Generic dialect. This results in possible conficts if canonical results are compared for all dialects if a column is named 'key' without quotes.
Pull Request Test Coverage Report for Build 3216094339
💛 - Coveralls |
alamb
approved these changes
Oct 19, 2022
| /// | ||
| /// [1]: https://dev.mysql.com/doc/refman/8.0/en/create-table.html | ||
| Index { | ||
| /// Whether this index starts with KEY (true) or INDEX (false), to maintain the same syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
Theoretically, the behavior should be the same as CREATE INDEX, but we cannot make that assumption, so the parse is (almost) identical to the input. MySQL seems to be the only one to support this syntax. (1)
Now we can support statements like:
The supported syntax implemented here is:
[1] : https://dev.mysql.com/doc/refman/8.0/en/create-table.html