Add Expr::Tuple and parsing support, remove special case in DISTINCT clause#414
Merged
Conversation
9c4697a to
068c40d
Compare
alamb
commented
Feb 8, 2022
| ); | ||
|
|
||
| // Tuples can also be in the set | ||
| one_statement_parses_to( |
Pull Request Test Coverage Report for Build 1812838772
💛 - Coveralls |
alamb
commented
Feb 8, 2022
| None | ||
| }; | ||
|
|
||
| // Not Sure if Top should be cheked here as well. Trino doesn't support TOP. |
Contributor
Author
There was a problem hiding this comment.
this was added in #390 but is now covered by the general purpose Tuple parsing
e-dard
approved these changes
Feb 8, 2022
e-dard
left a comment
There was a problem hiding this comment.
I took a whizz through this and it made sense to me 👍
Contributor
|
@alamb Much appreciated!!! Looks great :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
@yuval-illumex is trying to support parenthesized expressions like
(a, b)in various places (see #390, and #391)I believe these are more commonly called
tupleorrowtypes in postgres or trino. Rather than adding special case handling for parens in various places, it would be better to simply support parsing tuples in generalChanges
distinctclauseReference:
This syntax is supported by postgres:
It is not supported by
mysql: