Skip to content

Support CHARSET and ENGINE clauses on CREATE TABLE for mysql#392

Merged
alamb merged 3 commits into
apache:mainfrom
antialize:mysql_improvements
Feb 8, 2022
Merged

Support CHARSET and ENGINE clauses on CREATE TABLE for mysql#392
alamb merged 3 commits into
apache:mainfrom
antialize:mysql_improvements

Conversation

@antialize

Copy link
Copy Markdown
Contributor

That adds support for various features missing to parse a specific phpmyadmin database export.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @antialize

Comment thread tests/sqlparser_mysql.rs

#[test]
fn parse_create_table_set_enum() {
let sql = "CREATE TABLE foo (bar SET('a', 'b'), baz ENUM('a', 'b'))";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Database changed
mysql> CREATE TABLE foo (bar SET('a', 'b'), baz ENUM('a', 'b'));
Query OK, 0 rows affected (0.01 sec)

@alamb alamb changed the title Mysql improvements Support CHARSET and ENGINE clauses on CREATE TABLE for mysql Feb 8, 2022
@alamb alamb merged commit e495969 into apache:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants