Fix #369 - Add Support in Date/Time keywords#383
Closed
yuval-illumex wants to merge 6 commits into
Closed
Conversation
alamb
reviewed
Dec 17, 2021
alamb
left a comment
Contributor
There was a problem hiding this comment.
I double checked that both mysql and postgres indeed do treat these specially:
👍
Thanks @yuval-illumex
mysql> select current_timestamp;
+---------------------+
| current_timestamp |
+---------------------+
| 2021-12-17 12:30:40 |
+---------------------+
1 row in set (0.00 sec)
mysql> select current_time;
+--------------+
| current_time |
+--------------+
| 12:30:45 |
+--------------+
1 row in set (0.00 sec)
mysql> select current_date;
+--------------+
| current_date |
+--------------+
| 2021-12-17 |
+--------------+
1 row in set (0.00 sec)
mysql> ^DBye
(arrow_dev) alamb@MacBook-Pro-2:~/Software/arrow-datafusion$ psql
psql (14.1)
Type "help" for help.
alamb=# select current_timestamp;
current_timestamp
-------------------------------
2021-12-17 12:30:59.547784-05
(1 row)
alamb=# select current_time;
current_time
--------------------
12:31:02.464701-05
(1 row)
alamb=# select current_date;
current_date
--------------
2021-12-17
(1 row)
Pull Request Test Coverage Report for Build 1616040264Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
alamb
approved these changes
Dec 21, 2021
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good -- thanks @yuval-illumex
houqp
approved these changes
Dec 24, 2021
Contributor
|
These appear to have been included in #391 so closing this one down |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #369
Add Support for:
CURRENT_TIMESTAMP
CURRENT_DATE
CURRENT_TIME
Which are function without args.