Skip to content

Add support for PostgreSQL UNLISTEN syntax and Add support for Postgres LOAD extension expr#1531

Merged
alamb merged 5 commits into
apache:mainfrom
wugeer:feat_add_unlisten_channel_for_pg
Nov 19, 2024
Merged

Add support for PostgreSQL UNLISTEN syntax and Add support for Postgres LOAD extension expr#1531
alamb merged 5 commits into
apache:mainfrom
wugeer:feat_add_unlisten_channel_for_pg

Conversation

@wugeer
Copy link
Copy Markdown
Contributor

@wugeer wugeer commented Nov 18, 2024

This PR supports two PostgreSQL syntaxes,one is

and the other is

It also introduces the following keywords:

  • UNLISTEN

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wugeer! left a couple comments

Comment thread tests/sqlparser_common.rs Outdated
Comment thread src/parser/mod.rs Outdated
Comment thread src/dialect/mod.rs Outdated
Comment thread src/dialect/postgresql.rs
@wugeer wugeer requested a review from iffyio November 19, 2024 05:07
@wugeer
Copy link
Copy Markdown
Contributor Author

wugeer commented Nov 19, 2024

@iffyio Thank you for reviewing the code. I've pushed the changes again. Looking forward to your next review :)

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wugeer!
cc @alamb

@alamb alamb merged commit 73947a5 into apache:main Nov 19, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Nov 19, 2024

Thanks @iffyio and @wugeer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants