Skip to content

Fix the parsing error in MSSQL for multiple statements that include DECLARE statements#1497

Merged
alamb merged 5 commits into
apache:mainfrom
wugeer:fix/issue_1450
Nov 13, 2024
Merged

Fix the parsing error in MSSQL for multiple statements that include DECLARE statements#1497
alamb merged 5 commits into
apache:mainfrom
wugeer:fix/issue_1450

Conversation

@wugeer
Copy link
Copy Markdown
Contributor

@wugeer wugeer commented Nov 1, 2024

This PR resolves an error in MSSQL that occurs when parsing multiple SQL statements containing DECLARE statements.

before
parse sql in mssql

declare @a int;
set @a = 2;
select @a * 4;

raise error

Error during parsing: ParserError("Expected: end of statement, found: set at Line: 2, Column: 1")

This resolves issue #1450

@wugeer wugeer changed the title Fix the parsing error in MSSQL for multiple statements that include `… Fix the parsing error in MSSQL for multiple statements that include DECLARE statements Nov 4, 2024
iffyio
iffyio reviewed Nov 6, 2024
View reviewed changes
Comment thread src/parser/mod.rs Outdated
Comment thread tests/sqlparser_mssql.rs Outdated
@wugeer wugeer requested a review from iffyio November 6, 2024 23:10
iffyio
iffyio approved these changes Nov 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wugeer!
cc @alamb

@iffyio
Copy link
Copy Markdown
Contributor

iffyio commented Nov 9, 2024

@wugeer in the meantime when you get the chance could you take a look at the compile issue? i think it likely just needs the latest changes from main incorporated

@wugeer
Fix the parsing error in MSSQL for multiple statements that include `…
a72ea54 
…DECLARE` statements.

before
parse sql in mssql
```
declare @A int;
set @A = 2;
select @A * 4;
```
raise error
```
Error during parsing: ParserError("Expected: end of statement, found: set at Line: 2, Column: 1")
```
@wugeer
Make the logic for exiting the parse_mssql_declare loop more precise
612dc40
@wugeer
Use a more consistent approach
258645a
@wugeer
Parse the MSSQL DECLARE statement in a more rustc-like manner
f42952e
@wugeer
Copy link
Copy Markdown
Contributor Author

wugeer commented Nov 9, 2024

@iffyio Thank you for your guidance. I have already fixed it. :)

@alamb alamb merged commit 632ba4c into apache:main Nov 13, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Nov 13, 2024

Thanks again @wugeer and @iffyio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iffyio iffyio iffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wugeer @iffyio @alamb