Skip to content

Support EXPLAIN / DESCR / DESCRIBE [FORMATTED | EXTENDED]#1156

Merged
alamb merged 8 commits into
apache:mainfrom
jonathanlehto:extended_formatted
Mar 1, 2024
Merged

Support EXPLAIN / DESCR / DESCRIBE [FORMATTED | EXTENDED]#1156
alamb merged 8 commits into
apache:mainfrom
jonathanlehto:extended_formatted

Conversation

@jonathanlehto

Copy link
Copy Markdown
Contributor

@coveralls

coveralls commented Feb 29, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8115996810

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 38 of 40 (95.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 87.815%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 9 10 90.0%
tests/sqlparser_common.rs 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 82.86%
Totals Coverage Status
Change from base Build 8115901117: 0.008%
Covered Lines: 20389
Relevant Lines: 23218

💛 - Coveralls

@alamb alamb changed the title adding extended and formatted Support DESCRIBE [FORMATTED | EXTENDED] Mar 1, 2024
Comment thread src/ast/mod.rs
@alamb alamb changed the title Support DESCRIBE [FORMATTED | EXTENDED] Support EXPLAIN / DESCR / DESCRIBE [FORMATTED | EXTENDED] Mar 1, 2024

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always thanks again. I have a few small comment improvements, but I'll plan to make them myself

Comment thread src/ast/mod.rs Outdated
Comment thread src/ast/mod.rs Outdated
@alamb alamb merged commit ef46680 into apache:main Mar 1, 2024
@jonathanlehto

Copy link
Copy Markdown
Contributor Author

Thank you @alamb ! I appreciate the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants