Skip to content

adding delimited#1155

Merged
alamb merged 4 commits into
apache:mainfrom
jonathanlehto:delimited
Mar 1, 2024
Merged

adding delimited#1155
alamb merged 4 commits into
apache:mainfrom
jonathanlehto:delimited

Conversation

@jonathanlehto

Copy link
Copy Markdown
Contributor

adding delimited properties to for hive

Hive Delimited Properties -- https://spark.apache.org/docs/latest/sql-ref-syntax-hive-format.html

@coveralls

coveralls commented Feb 29, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8102760901

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 55 of 60 (91.67%) changed or added relevant lines in 3 files are covered.
  • 435 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 87.807%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 16 17 94.12%
src/parser/mod.rs 36 40 90.0%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_mysql.rs 6 99.54%
tests/sqlparser_clickhouse.rs 8 96.04%
src/tokenizer.rs 13 89.92%
src/dialect/mod.rs 14 80.53%
tests/sqlparser_postgres.rs 14 97.95%
src/parser/mod.rs 93 82.87%
src/ast/mod.rs 287 79.73%
Totals Coverage Status
Change from base Build 8096363009: 0.02%
Covered Lines: 20301
Relevant Lines: 23120

💛 - Coveralls

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 6f090e5 into apache:main Mar 1, 2024
@jonathanlehto

Copy link
Copy Markdown
Contributor Author

Thank you @alamb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants