Skip to content

Support Unload statement#1150

Merged
alamb merged 5 commits into
apache:mainfrom
jonathanlehto:unload
Feb 29, 2024
Merged

Support Unload statement#1150
alamb merged 5 commits into
apache:mainfrom
jonathanlehto:unload

Conversation

@jonathanlehto

@jonathanlehto jonathanlehto commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Comment thread tests/sqlparser_common.rs

#[test]
fn parse_unload() {
let unload = verified_stmt("UNLOAD(SELECT cola FROM tab) TO 's3://...' WITH (format = 'AVRO')");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating -- I haven't seen UNLOAD before

@alamb

alamb commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Thank you very much @jonathanlehto for this contribution

@alamb

alamb commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

I took the liberty of merging the branch up from main to fix a merge conflict, as well as fixing a clippy issue

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8101765167

Details

  • 62 of 62 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.914%

Totals Coverage Status
Change from base Build 8101602088: 0.03%
Covered Lines: 20265
Relevant Lines: 23051

💛 - Coveralls

@alamb alamb merged commit e2ce324 into apache:main Feb 29, 2024
@alamb

alamb commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Thanks again @jonathanlehto

@jonathanlehto

Copy link
Copy Markdown
Contributor Author

No problem, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants