tsaucer/run TPC-H examples in CI#711
Merged
andygrove merged 6 commits intoMay 21, 2024
Merged
Conversation
… for the files regardless of where it is run from. There are a few small updates to make the tests match the expected answer file provided by dbgen.
…such as when running in CI
Member
Author
|
@Michael-J-Ward It looks like we have a potential regression between 37.1.0 and 38.0.0. Namely This PR includes exposing |
andygrove
approved these changes
May 21, 2024
Member
andygrove
left a comment
There was a problem hiding this comment.
Awesome. Thank you @timsaucer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #696
Closes #712
Rationale for this change
This PR sets up a work flow to generate TPH-C 1Gb data set in CI, runs the 22 examples, and compares their results to the
known answer file. By adding this PR we improve the robustness of our test suite.
What changes are included in this PR?
This PR adds the following changes:
Are there any user-facing changes?
substringfunction exposed in python.Additional context
This PR replaces #710 which contains a lot of intermediate testing steps. This MR should be cleaner to review.