Skip to content

Upgrade to DataFusion 12.0.0#53

Merged
andygrove merged 2 commits into
apache:masterfrom
andygrove:datafusion-12.0.0
Sep 16, 2022
Merged

Upgrade to DataFusion 12.0.0#53
andygrove merged 2 commits into
apache:masterfrom
andygrove:datafusion-12.0.0

Conversation

@andygrove
Copy link
Copy Markdown
Member

No description provided.

@andygrove
Copy link
Copy Markdown
Member Author

@francis-du Could you review when you have time?

@francis-du
Copy link
Copy Markdown
Contributor

francis-du commented Sep 16, 2022

@francis-du Could you review when you have time?

No problem

Copy link
Copy Markdown
Contributor

@francis-du francis-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/dataset_exec.rs
use datafusion::physical_plan::{
DisplayFormatType, ExecutionPlan, Partitioning, SendableRecordBatchStream, Statistics,
};
use datafusion_expr::{combine_filters, Expr};
Copy link
Copy Markdown
Contributor

@francis-du francis-du Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think datafusion::logical_plan in expression.rs#L22 also needs to be replaced with datafusion_expr

@andygrove andygrove merged commit 259f2e4 into apache:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants