Skip to content

Revert "build(deps): bump arduino/setup-protoc from 1 to 2 (#452)"#474

Merged
andygrove merged 1 commit into
apache:mainfrom
viirya:fix_ci2
Sep 8, 2023
Merged

Revert "build(deps): bump arduino/setup-protoc from 1 to 2 (#452)"#474
andygrove merged 1 commit into
apache:mainfrom
viirya:fix_ci2

Conversation

@viirya

@viirya viirya commented Sep 7, 2023

Copy link
Copy Markdown
Member

This reverts commit 944b1c9.

Which issue does this PR close?

Closes #472.

Rationale for this change

This follows the suggestion from arduino/setup-protoc#85. Based on it, setup-protoc@v2 is for v21.0. We should setup-protoc@v1.

What changes are included in this PR?

Are there any user-facing changes?

@viirya

viirya commented Sep 7, 2023

Copy link
Copy Markdown
Member Author

The step Install Protoc is passed in these workflows.

@viirya

viirya commented Sep 7, 2023

Copy link
Copy Markdown
Member Author

cc @alamb @andygrove

@viirya viirya mentioned this pull request Sep 7, 2023
@alamb

alamb commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

I don't know a whole lot about this repo, but the change seems reasonable to me

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@andygrove andygrove merged commit b4d383b into apache:main Sep 8, 2023
@viirya

viirya commented Sep 8, 2023

Copy link
Copy Markdown
Member Author

Thank you @alamb @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI broken after upgrading setup-protoc

3 participants