You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh... CI doesn't catch this because we run pytest on linux only. I wonder if there's reason enough to run it on windows/mac on merge to main? I don't think we need to run it on every PR commit because that would mean keeping more artifacts, but on merges to main we do get full release builds for all wheels.
Oh... CI doesn't catch this because we run pytest on linux only. I wonder if there's reason enough to run it on windows/mac on merge to main? I don't think we need to run it on every PR commit because that would mean keeping more artifacts, but on merges to main we do get full release builds for all wheels.
It would be nice to run them on main just in case. However, in my experience the errors are usually related to paths or some specific functionality required by the tests, so I think it's also not critical to run them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
Only
spawnis supported on Windows, so skipforkandforkserverintest_pickle_multiprocessing.What changes are included in this PR?
test_pickle_multiprocessingtests.Are there any user-facing changes?
No.